linux-ext4 - Re: [BUG] e2fsprogs: e2fsck -b outputs checksum warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <27A3067E-93E0-4452-968F-94634A72E546@dilger.ca>
Date:	Tue, 31 Jan 2012 15:17:40 -0700
From:	Andreas Dilger <adilger@...ger.ca>
To:	Ted Ts'o <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>,
	Akira Fujita <a-fujita@...jp.nec.com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [BUG] e2fsprogs: e2fsck -b outputs checksum warnings

On 2012-01-31, at 1:56 PM, Ted Ts'o wrote:
>>> One or more block group descriptor checksums are invalid.  Fix<y>? yes
>>> 
>>> Group descriptor 0 checksum is invalid.  FIXED.
>>> Group descriptor 1 checksum is invalid.  FIXED.
>>> Group descriptor 2 checksum is invalid.  FIXED.
>>> Group descriptor 3 checksum is invalid.  FIXED.
> 
> This is certainly scary, though.  In the case where we do need to use
> the backup block group descriptors, it would be better to reset the
> checksum to the correct value so we don't get all of this extra
> output, which isn't useful to the user and is just going to alarm them
> unnecessarily.

I was thinking this is just an oversight in the code which is removing the
UNINIT flags.  It should just recompute the group checksum (which will
happen only rarely, and the performance isn't critical).

A patch has been submitted separately.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html