linux-ext4 - Re: [PATCH 2/2] ext3: Don't update ctime in ext3_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F28F021.8030904@sx.jp.nec.com>
Date:	Wed, 01 Feb 2012 16:56:17 +0900
From:	Kazuya Mio <k-mio@...jp.nec.com>
To:	Jan Kara <jack@...e.cz>
CC:	ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH 2/2] ext3: Don't update ctime in ext3_splice_branch()

2012/01/31 2:52, Jan Kara wrote:
>   Thanks for the patches.  This is true for ordinary writes but not true
> when you write via mmap. We call file_update_time() during page fault so
> ctime won't be completely wrong but still we should update it after block
> is allocated during writeback to reflect that new block is allocated to
> the inode.

Should we update ctime whenever a block is allocated?
If so, ordinary write in ext4 with indirect block mapping has the same problem
due to the following patch, right?
http://marc.info/?l=linux-ext4&m=124505184027078&w=4

Regards,
Kazuya Mio
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html