linux-ext4 - Re: sparsify - utility to punch out blocks of 0s in a file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F2F146B.6050003@msgid.tls.msk.ru>
Date:	Mon, 06 Feb 2012 03:44:43 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Eric Sandeen <sandeen@...hat.com>
CC:	ext4 development <linux-ext4@...r.kernel.org>,
	xfs-oss <xfs@....sgi.com>
Subject: Re: sparsify - utility to punch out blocks of 0s in a file

On 05.02.2012 00:10, Eric Sandeen wrote:
[]

Just a very quick look:

>  * sparsify - utility to punch out blocks of 0s in a file
> int main(int argc, char **argv)
> {
[]
> 	if (optind == argc) {
> 		printf("Error: no filename specified\n");
> 		usage();
> 	}
> 
> 	fname = argv[optind++];

There's no handling of the case when there are more than one file
specified on the command line.


> 	/*
> 	 * Normalize to blocksize-aligned range:
> 	 * round start down, round end up - get all blocks including the range specified
> 	 */
> 
> 	punch_range_start = round_down(punch_range_start, blocksize);
> 	punch_range_end = round_up(punch_range_end, blocksize);
> 	min_hole = round_up(min_hole, blocksize);
> 	if (!min_hole)
> 		min_hole = blocksize;

I think this deserves some bold warning if punch_range_start
or punch_hole_end is not a multiple of blocksize.

[]
> 	/*
> 	 * Read through the file, finding block-aligned regions of 0s.
> 	 * If the region is at least min_hole, punch it out.
> 	 * This should be starting at a block-aligned offset
> 	 */
> 
> 	while ((ret = read(fd, readbuf, min_hole)) > 0) {
> 
> 		if (!memcmp(readbuf, zerobuf, min_hole)) {

Now this is interesting.  Can ret be < min_hole?  Can a read
in a middle of a file be shorter than specified?

How it will work together with some other operation being done
at the same file -- ftruncate anyone?

Thanks!

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html