linux-ext4 - Re: Collapsing the number of feature flags (was Re: [PATCH v2.3 00/23] ext4: Add metadata checksumming)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120212025518.GA22492@thunk.org>
Date:	Sat, 11 Feb 2012 21:55:18 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	"Darrick J. Wong" <djwong@...ibm.com>, linux-ext4@...r.kernel.org
Subject: Re: Collapsing the number of feature flags (was Re: [PATCH v2.3
 00/23] ext4: Add metadata checksumming)

On Sat, Feb 11, 2012 at 06:38:03PM -0700, Andreas Dilger wrote:
> 
> I think that making it difficult for users to use anything but the default
> options in mke2fs/tune2fs/debugfs is equivalent to what you suggest.
> Unless you prevent the use of the old feature flags entirely, then it
> would still be possible to create filesystems with mixed up combinations
> of features.  I think the important outcome is that users are clearly
> made aware that they are stepping off the well-trodden path, and if
> things break they get to keep both pieces.  Having two feature flags
> that mean the same thing doesn't really help this, IMHO.

The problem is that sometimes people upgrade the kernel before they
upgrade userspace, and sometimes they upgrade e2fsprogs but are still
running an older kernel --- and there times when those are good and
proper things to do (i.e., they have to use some ancient obsolete RHEL
kernel becuase it's they only way they can talk to the EMC storage
device, but they want to use a newer e2fsprogs to fix bugs that have
since been fixed in the latest version of e2fsprogs).

So we have to support both, and so yes, we can't remove any code for
quite a while.  What we *can* do is say that if you enable metadata
checksums, you also must get all of these other features along for the
ride.  It's true that means users can still create mixed up feature
set --- but not if they want the new metadata checksum feature. 

It's an eventual solution, but it's not magic pixie dust, yes.
Realistically most of the time we haven't had *that* many problems
caused by random feature combinations.  There are certain combinations
that are problematic, but we know what they are up front.

If someone really wants to add that screen for certain feature
combinations and causes mke2fs/e2fsck to complain, or maybe even
outright refuse to function, that's a different thing, that's going to
be fairly specific for the distro.  I don't think that's something we
want to add upstream....

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html