linux-ext4 - Re: [PATCH] ext4: expand commit callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4FC52D3C-E489-43A7-96BB-433D0E8F15CB@whamcloud.com>
Date:	Mon, 13 Feb 2012 16:50:57 -0700
From:	Andreas Dilger <adilger@...mcloud.com>
To:	Ted Ts'o <tytso@....edu>
Cc:	Bobi Jam <bobijam@...mcloud.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: expand commit callback

On 2012-02-13, at 2:02 PM, Ted Ts'o wrote:
> On Wed, Oct 26, 2011 at 06:49:16PM +0800, Bobi Jam wrote:
>> The per-commit callback is now used by mballoc code to manage free
>> space bitmaps after deleted blocks have been released. This patch
>> expand it to contain multiple different callbacks.
>> 
>> Signed-off-by: Bobi Jam <bobijam@...mcloud.com>
>> Signed-off-by: Andreas Dilger <adilger@...mcloud.com>
> 
> Thanks, applied.
> 
> Note: since this callback is called *after* the commit is completed,
> we can't really use this to do things like compute metadata checksums
> or update atimes more efficiently, since those sorts of things have to
> happen *before* we actually finish up the commit.

Right, though a similar commit callback (using the same infrastructure)
could be added before the commit is started.

There is already the buffer_head callback that OCFS is using for their
data checksums, which is called before the transaction commit.  I haven't
looked at that closely enough to know whether the ext4 metadata checksums
could use it (e.g. if it can handle different metadata block types with
different checksum chunks and locations).

Cheers, Andreas
--
Andreas Dilger                       Whamcloud, Inc.
Principal Lustre Engineer            http://www.whamcloud.com/




--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html