linux-ext4 - Re: [PATCH] libext2fs: Only link an inode into a directory once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120215222342.GB20023@thunk.org>
Date:	Wed, 15 Feb 2012 17:23:42 -0500
From:	Ted Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <djwong@...ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] libext2fs: Only link an inode into a directory once

On Wed, Feb 15, 2012 at 12:40:15PM -0800, Darrick J. Wong wrote:
> 
> Yes.  I took a look at the block iteration code again, and I'm
> wondering, do we need one of these:
> 
> if (ret & BLOCK_ABORT)
> 	break;
> 
> ...around lib/ext2fs/block.c, line 450?

Good spotting; it turns out there was another problem later on, where the

	if (ret & BLOCK_ABORT)
		break;

does the wrong thing, since we need to break out of both the for loop
*and* the while loop.

I'll send a patch which I believe will fix BLOCK_ABORT in the block
iterator for the extent case.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html