lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 20 Feb 2012 18:17:38 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Theodore Ts'o" <tytso@....edu>
CC:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsck: check new sysfs interface to determine if we
 are on battery

On 2/20/12 6:11 PM, Theodore Ts'o wrote:
> ...since the old way is deprecated.
> 
> Addresses-SourceForge-Bug: #3439277

Red Hat bug #644629 too

But https://bugzilla.redhat.com/show_bug.cgi?id=644629#c5
made it sound harder than this, so I was ... keeping that bug
on the back burner ...

> You need to enumerate through all power supply devices with the "type" =
> "Mains" attribute, and check if any of them have the "online" attribute as "1".
> If so you have AC power. If don't find any power supply of "type" = "Mains"
> then you are on AC power too. Only if you have one or more power supplies of
> "type" = "Mains" and all of them have "online" = "0" then you are on battery.

If your patch fixes the general case, I say go for it! :)

-Eric

> 
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>  e2fsck/unix.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/e2fsck/unix.c b/e2fsck/unix.c
> index c38b67a..6f97b0f 100644
> --- a/e2fsck/unix.c
> +++ b/e2fsck/unix.c
> @@ -252,6 +252,14 @@ static int is_on_batt(void)
>  	unsigned int	acflag;
>  	struct dirent*	de;
>  
> +	f = fopen("/sys/class/power_supply/AC/online", "r");
> +	if (f) {
> +		if (fscanf(f, "%d\n", &acflag) == 1) {
> +			fclose(f);
> +			return (!acflag);
> +		}
> +		fclose(f);
> +	}
>  	f = fopen("/proc/apm", "r");
>  	if (f) {
>  		if (fscanf(f, "%s %s %s %x", tmp, tmp, tmp, &acflag) != 4)

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists