lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 20 Feb 2012 23:00:07 -0500
From:	Ted Ts'o <>
To:	Jeff Moyer <>
Subject: Re: [patch, resend] ext4: fix race between unwritten extent
 conversion and truncate

On Thu, Feb 16, 2012 at 03:26:48PM -0500, Jeff Moyer wrote:
> Hi,
> The following comment in ext4_end_io_dio caught my attention:
> 	/* XXX: probably should move into the real I/O completion handler */
>         inode_dio_done(inode);
> The truncate code takes i_mutex, then calls inode_dio_wait.  Because the
> ext4 code path above will end up dropping the mutex before it is
> reacquired by the worker thread that does the extent conversion, it
> seems to me that the truncate can happen out of order.  Jan Kara
> mentioned that this might result in error messages in the system logs,
> but that should be the extent of the "damage."
> The fix is pretty straight-forward: don't call inode_dio_done until the
> extent conversion is complete.
> Signed-off-by: Jeff Moyer <>
> Reviewed-by: Jan Kara <>

Thanks, applied.

						- Ted
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists