linux-ext4 - Re: [PATCH 1/2 v2] e2fsck: Discard only unused parts of inode table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1202270759180.5597@dhcp-27-109.brq.redhat.com>
Date:	Mon, 27 Feb 2012 08:03:46 +0100 (CET)
From:	Lukas Czerner <lczerner@...hat.com>
To:	"Ted Ts'o" <tytso@....edu>
cc:	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org,
	psusi@...ntu.com, sandeen@...hat.com
Subject: Re: [PATCH 1/2 v2] e2fsck: Discard only unused parts of inode
 table

On Mon, 27 Feb 2012, Ted Ts'o wrote:

> On Thu, Feb 23, 2012 at 05:29:25PM +0100, Lukas Czerner wrote:
> > When calling e2fsck with '-E discard' option it might happen that
> > valid inodes are discarded accidentally. This is because we just
> > discard the part of inode table which lies past the highest used
> > inode. This is terribly wrong (sorry!).
> 
> Is this description accurate?  We *do* want to discard the part of the
> inode table past the highest used inode number.  By definition
> everything past that to the end of the bg's inode table is unsued,
> right?  The problem was before we were using the free inode count as I
> understand things.
> 
> 						- Ted
> 

Once again with my terrible English expressions. Yes, we were using free
inode count, which is wrong. Now we discard every free extent in the
inode table. I'll update the description.

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html