linux-ext4 - Re: mkfs.ext4 vs. e2fsck discard oddities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1203011540180.6491@dhcp-27-109.brq.redhat.com>
Date:	Thu, 1 Mar 2012 15:54:37 +0100 (CET)
From:	Lukas Czerner <lczerner@...hat.com>
To:	"Ted Ts'o" <tytso@....edu>
cc:	Lukas Czerner <lczerner@...hat.com>,
	Eric Sandeen <sandeen@...hat.com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: mkfs.ext4 vs. e2fsck discard oddities

On Thu, 1 Mar 2012, Ted Ts'o wrote:

> On Thu, Mar 01, 2012 at 08:12:44AM +0100, Lukas Czerner wrote:
> > 
> > actually mke2fs does discard block by default. It has been like that
> > since the beginning. Back then we only had '-K' argument to 'keep'
> > blocks and do not attempt to discard. Nowadays user can do '-E
> > nodiscard', but it is users choice.
> 
> Ah, you're right.  The defaults had changed back and forth a couple of
> times over time and I had lost track of how things had been settled
> for mke2fs (which is different from e2fsck).  At least at one point it
> was _not_ the default, and in fact the man page was out of sync with
> the behavior of the mke2fs.

I am really not sure about that, I know that there was a discussion
whether to disable it by default, but I think that we never did that.
But that's not important.

> 
> The point remains the same, though, if the file system was created
> with mke2fs -E nodiscard, how do you undo that decision if there's no
> way to force the discard of BLOCK_UNINIT blocks?
> 
> 						- Ted
> 

Well, it is not default right ? So the user should better know what is
he doing. Moreover it is not like it is end of the world when we do not
provide that option, since SSD's will handle over provisioning to some
extent even without slowdown, and as for thin-provisioned devices you
should know why you're overriding defaults and what it means for you.

Anyway, if people really want this another option to discard all the
block groups including those UNINIT ones, I guess I can not resist that
:). '-E discard_all' maybe ?

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html