linux-ext4 - Re: [PATCH 3/4 v2] ext4: Always set then trimmed blocks count into len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120305123839.GF6643@quack.suse.cz>
Date:	Mon, 5 Mar 2012 13:38:39 +0100
From:	Jan Kara <jack@...e.cz>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH 3/4 v2] ext4: Always set then trimmed blocks count into
 len

On Fri 02-03-12 13:11:57, Lukas Czerner wrote:
> Currently if the range to trim is too small, for example on 1K fs
> the request to trim the first block, then the 'range->len' is not set
> reporting wrong number of discarded block to the caller.
> 
> Fix this by always setting the 'range->len' before we return. Note that
> when there is a failure (-EINVAL) caller can not depend on 'range->len'
> being set properly.
  Looks good. You can add:
Reviewed-by: Jan Kara <jack@...e.cz>

								Honza
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> ---
> v2: nothing changed
> 
>  fs/ext4/mballoc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index f20688e..8f817f2 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -5092,11 +5092,11 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range)
>  		 */
>  		first_cluster = 0;
>  	}
> -	range->len = trimmed * sb->s_blocksize;
>  
>  	if (!ret)
>  		atomic_set(&EXT4_SB(sb)->s_last_trim_minblks, minlen);
>  
>  out:
> +	range->len = trimmed * sb->s_blocksize;
>  	return ret;
>  }
> -- 
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html