linux-ext4 - Re: [patch] ext4: clean up the flags passed to __blockdev_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120305152509.GA21356@thunk.org>
Date:	Mon, 5 Mar 2012 10:25:09 -0500
From:	Ted Ts'o <tytso@....edu>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [patch] ext4: clean up the flags passed to
 __blockdev_direct_IO for extent-based files

On Fri, Feb 24, 2012 at 04:49:21PM -0500, Jeff Moyer wrote:
> Hi,
> 
> For extent-based files, you can perform DIO to holes, as mentioned in
> the comments in ext4_ext_direct_IO.  However, that function passes
> DIO_SKIP_HOLES to __blockdev_direct_IO, which is *really* confusing to
> the uninitiated reader.  The key, here, is that the get_block function
> passed in, ext4_get_block_write, completely ignores the create flag that
> is passed to it (the create flag is passed in from the direct I/O code,
> which uses the DIO_SKIP_HOLES flag to determine whether or not it should
> be cleared).
> 
> This is a long-winded way of saying that the DIO_SKIP_HOLES flag is
> ultimately ignored.  So, in the interest of preserving sanity, I propose
> the following patch.
> 
> Signed-off-by: Jeff Moyer <jmoyer@...hat.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html