linux-ext4 - Re: [PATCH 1/1] ext4: Remove empty index blocks when punching holes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1203060810430.5085@dhcp-27-109.brq.redhat.com>
Date:	Tue, 6 Mar 2012 08:11:37 +0100 (CET)
From:	Lukas Czerner <lczerner@...hat.com>
To:	"Ted Ts'o" <tytso@....edu>
cc:	Lukas Czerner <lczerner@...hat.com>,
	Allison Henderson <achender@...ux.vnet.ibm.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/1] ext4: Remove empty index blocks when punching
 holes

On Mon, 5 Mar 2012, Ted Ts'o wrote:

> On Wed, Feb 29, 2012 at 09:18:54AM +0100, Lukas Czerner wrote:
> > > 
> > > Alrighty then, sounds good.  This patch seemed to correct the loop discard bug
> > > we saw earlier for me.  So please make sure you have some similar fix in your
> > > new patch.  Basically we had some extra index blocks hanging around when the
> > > depth was greater than one, so the patch just adds some code to free up those
> > > index blocks in the path if they are empty.  Hope this helps!  Thx!  :)
> > 
> > Actually I started to modifying the punch hole code in order to find
> > that bug and this problem does go away with my pathes. I'll CC
> > you on the patches when I send them out.
> 
> OK, so my understanding is that Lukas's patches solve the same problem
> as Allison's, and those are the patches I should review and integrate?
> 
>    	      	  	    		- Ted
> 

Hi Ted,

you're right my patches solves this problem (as I wrote in the commit
description) just because we now use a different code paths, which do
not have this problem.

Thanks!
-Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html