linux-ext4 - Re: ext3/4, btrfs, ocfs2: How to assure that cleancache_invalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120312133825.GF5998@quack.suse.cz>
Date:	Mon, 12 Mar 2012 14:38:25 +0100
From:	Jan Kara <jack@...e.cz>
To:	Andor Daam <andor.daam@...glemail.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-ext4@...r.kernel.org, ocfs2-devel@....oracle.com,
	dan.magenheimer@...cle.com, fschmaus@...il.com, linux-mm@...ck.org,
	ilendir@...glemail.com, sjenning@...ux.vnet.ibm.com,
	konrad.wilk@...cle.com, i4passt@...ts.informatik.uni-erlangen.de,
	ngupta@...are.org
Subject: Re: ext3/4, btrfs, ocfs2: How to assure that
 cleancache_invalidate_fs is called on every superblock free

  Hello,

On Fri 09-03-12 14:40:22, Andor Daam wrote:
> Is it ever possible for a superblock for a mounted filesystem to be
> free'd without a previous call to unmount the filesystem?
  No, I don't think so (well, except for cases where we do not manage to
fully setup the superblock). But be aware that mount/umount need not be
really the entry points you are looking for since filesystem can be mounted
several times. Rather deactivate_locked_supers() is the place you are
looking for...

> I need to be certain that the function cleancache_invalidate_fs, which is
> at the moment called by deactivate_locked_super (fs/super.c) [1], is
> called before every free on a superblock of cleancache-enabled
> filesystems.  Is this already the case or are there situations in which
> this does not happen?
> 
> It would be interesting to know this, as we are planning to have
> cleancache save pointers to superblocks of every mounted
> cleancache-enabled filesystem [2] and it would be fatal if a
> superblock is free'd without cleancache being notified.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html