linux-ext4 - Re: [PATCH 2/9] ext4: Use pr_fmt and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120319043420.GL31682@thunk.org>
Date:	Mon, 19 Mar 2012 00:34:20 -0400
From:	Ted Ts'o <tytso@....edu>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] ext4: Use pr_fmt and pr_<level>

On Mon, Mar 19, 2012 at 12:14:30AM -0400, David Miller wrote:
> 
> I apply patches like Joe's all the time to the networking, consistency
> has high value whether you choose to believe it or not.  And no we
> don't have huge problems with patch conflicts and stuff like that
> either, it simply isn't a real issue so don't use that as an excuse
> either.
> 

It is for me.

Things like printk(KERN_INFO, ...) are quite well established, and
changing really doesn't add any value.  Sorry, I just don't buy the
consistency argument.  I'd much rather keep everything consistent
within ext3 and ext4.

If you want to apply those sorts of patches, feel free.  I choose not
to, and I actively discourage kernel newbies from running
checkpatch.pl --file and trying to fix random things.  (A few years
ago everyone agreed that that was a waste of time.)

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html