linux-ext4 - Re: [PATCH 3/4 v2] ext4: Always set then trimmed blocks count into len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120322012301.GD11157@thunk.org>
Date:	Wed, 21 Mar 2012 21:23:01 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/4 v2] ext4: Always set then trimmed blocks count into
 len

On Mon, Mar 05, 2012 at 01:38:39PM +0100, Jan Kara wrote:
> On Fri 02-03-12 13:11:57, Lukas Czerner wrote:
> > Currently if the range to trim is too small, for example on 1K fs
> > the request to trim the first block, then the 'range->len' is not set
> > reporting wrong number of discarded block to the caller.
> > 
> > Fix this by always setting the 'range->len' before we return. Note that
> > when there is a failure (-EINVAL) caller can not depend on 'range->len'
> > being set properly.
>   Looks good. You can add:
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html