linux-ext4 - Re: [PATCH 4/5] libext2fs: Implement ext2fs_find_first_zero_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 11:34:31 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Sami Liedes <sami.liedes@....fi>
Cc:	Andreas Dilger <adilger@...ger.ca>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 4/5] libext2fs: Implement
 ext2fs_find_first_zero_generic_bmap().

On Mon, Mar 26, 2012 at 04:53:56PM +0300, Sami Liedes wrote:
> > So I plan to pull in your patch series and then we can further enhance
> > this with iterator support afterwards.  Sami, if you'd be interested
> > in implementing iterators, that would be great!
> 
> Just to be on the same page, what is the motivation for iterators? Is
> it performance, making the code cleaner or facilitating further
> functionality?

It's a little of all three.  For example, in e2fsck's pass #5, we
currently test each bit, one at a time.  The code paths are quite
complex, but given that we're already using an rbtree for block and
inode bitmaps in e2fsck, using a find_first_set() function could
significantly improve performance.  (We can't really use an iterator
since we need to stop at each block group boundary to check the bg
summary values, but that's where using a find_first_set() with an
"upto" field would do what we want.)

I'll note by the way that it's possible for resize2fs, if we implement
find_first_set() and find_first_zero() for rbtree bitmaps, using
rbtree bitmaps could be even faster, since even with your
optimizations, if there are large blocks of unset bitmaps, we have to
check every single memory location in a bitarray, where as a rbtree
bitmap is much more space compact and would also be faster from a
"find_first_set" standpoint.

There are a few other places where it would make the code cleaner, and
where I might switch to using an rbtree-backed bitmap instead of a
sorted array implementation, but that's a secondary concern.

Cheers,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html