linux-ext4 - Re: [PATCH] ext4: do not enable delalloc by default for ext2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F71DE12.2090700@redhat.com>
Date:	Tue, 27 Mar 2012 10:34:42 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Brian Foster <bfoster@...hat.com>
CC:	linux-ext4@...r.kernel.org, Eric Sandeen <esandeen@...hat.com>
Subject: Re: [PATCH] ext4: do not enable delalloc by default for ext2

On 3/27/12 8:46 AM, Brian Foster wrote:
> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.

This makes sense to me, I think.

It was done for ext3 to semi-preserve the journal "5s sync" I think, and
one could argue that delalloc is ok for ext2, but it seems like people would
expect behavior which is as close to what ext2.ko provided as possible.  So,

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

> Signed-off-by: Brian Foster <bfoster@...hat.com>
> ---
>  fs/ext4/super.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9339009..b08a547 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>  	 * enable delayed allocation by default
>  	 * Use -o nodelalloc to turn it off
>  	 */
> -	if (!IS_EXT3_SB(sb) &&
> +	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
>  	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
>  		set_opt(sb, DELALLOC);
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html