linux-ext4 - Commit c1a1e7fc24d6 causes segfault in ext2fs_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120330125726.GA26221@amd.home.annexia.org>
Date:	Fri, 30 Mar 2012 13:57:26 +0100
From:	"Richard W.M. Jones" <rjones@...hat.com>
To:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc:	Sami Liedes <sami.liedes@....fi>
Subject: Commit c1a1e7fc24d6 causes segfault in ext2fs_new_inode

[I'm tracking this issue here:
https://bugzilla.redhat.com/show_bug.cgi?id=808421]

febootstrap uses the ext2fs library to construct an ext2 filesystem.

Since we updated to the latest version in git, febootstrap segfaults
in ext2fs_find_first_zero_generic_bmap (called from ext2fs_new_inode).
There's a complete stack trace in the bug above.

I'm not claiming that we are calling this library correctly, but,
you know, "it always worked until now".

Here is the calling code:

https://github.com/libguestfs/febootstrap/blob/636a80b5a70382f21da47c44a0acd3efa2bc7fcf/helper/ext2.c#L142

git bisect points to this change being the one which causes the
problem:

c1a1e7fc24d6e37f931bbb8eeb29c90243f0a55d is the first bad commit
commit c1a1e7fc24d6e37f931bbb8eeb29c90243f0a55d
Author: Sami Liedes <sami.liedes@....fi>
Date:   Sat Mar 10 22:36:12 2012 +0200

    libext2fs: Implement ext2fs_find_first_zero_generic_bmap().

    This function searches a bitmap for the first zero bit within a range.
    It checks if there is a bitmap backend specific implementation
    available (if the relevant field in bitmap_ops is non-NULL). If not,
    it uses a generic and slow method by repeatedly calling test_bmap() in
    a loop. Also change ext2fs_new_inode() to use this new function.

    This change in itself does not result in a large speedup, rather it
    refactors the code in preparation for the introduction of a faster
    find_first_zero() for bitarray based bitmaps.

    Signed-off-by: Sami Liedes <sami.liedes@....fi>
    Signed-off-by: Theodore Ts'o <tytso@....edu>

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html