lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 4 Apr 2012 00:36:32 +0200
From:	Jan Kara <jack@...e.cz>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Jan Kara <jack@...e.cz>,
	Ext4 Mailing List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext2: do not register write_super within VFS

On Tue 03-04-12 12:49:18, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
> 
> Jan Kara removed 'sb->s_dirt' VFS flag references, so we do not need to
> register the ext2 'ext2_write_super()' method in the VFS superblock operations,
> because 'sb->s_dirt' won't be ever set to 1 and VFS won't ever call
> '->write_super()' anyway. Thus, remove the method.
> 
> Tested using xfstests.
> 
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
  Thanks. Added to my tree.

									Honza

> ---
>  fs/ext2/super.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index a43f9ad..e0e8f45 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -302,7 +302,6 @@ static const struct super_operations ext2_sops = {
>  	.write_inode	= ext2_write_inode,
>  	.evict_inode	= ext2_evict_inode,
>  	.put_super	= ext2_put_super,
> -	.write_super	= ext2_write_super,
>  	.sync_fs	= ext2_sync_fs,
>  	.statfs		= ext2_statfs,
>  	.remount_fs	= ext2_remount,
> -- 
> 1.7.7.6
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists