linux-ext4 - Re: [PATCH] tests: add test for symlink extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Apr 2012 23:45:47 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...mcloud.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: add test for symlink extent

On Tue, Apr 10, 2012 at 03:34:17PM -0600, Andreas Dilger wrote:
> Long symlinks with the EXT4_EXTENTS_FL set may have been created at
> one time due to the EXTENTS_FL being inherited from the parent dir.
> While the original cause of such symlinks has been fixed in the
> upstream kernel commit 2dc6b0d48ca0599837df21b14bb8393d0804af57,
> such symlinks may still exist in the wild.

Huh?  We're still creating long symlinks with extents, and I'm not
sure why this would be a problem.  I don't mind a test for it, but it
seems strange that (a) you think e2fsprogs wouldn't be able to deal
with it, and (b) that we aren't doing it any more.  I just tested with
a 3.3 kernel with the patches from the ext4's 3.4 merge window, and it
created a symlink with an extent.

See line 872 of fs/ext4/ialloc.c:

	if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) {
		/* set extent flag only for directory, file and normal symlink*/
		if (S_ISDIR(mode) || S_ISREG(mode) || S_ISLNK(mode)) {
			ext4_set_inode_flag(inode, EXT4_INODE_EXTENTS);
			ext4_ext_tree_init(handle, inode);
		}
	}

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html