linux-ext4 - Re: [PATCH] tests: add test for symlink extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120411180718.GF12044@thunk.org>
Date:	Wed, 11 Apr 2012 14:07:18 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Andreas Dilger <adilger@...mcloud.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: add test for symlink extent

On Tue, Apr 10, 2012 at 11:06:50PM -0600, Andreas Dilger wrote:
> 
> My bad.  I had examined some symlinks on an ext4 filesystem to see
> if they had the EXT4_EXTENTS_FL set, but didn't think to check long
> symlinks, so I assumed this was an anachronism and rewrote the patch
> description while submitting it...  Originally it read:
> 
>     Long symlinks with the EXT4_EXTENTS_FL set should no longer be
>     considered as corrupt, since these are created by default with
>     new kernels using ext4 as the filesystem type.  This has not
>     impacted Lustre in the past because extents are only enabled on
>     the OST, while symlinks are only created on the MDT where extents
>     are never enabled.
>     
>     However, now that distros are using ext4 as the base filesystem
>     type, if the lustre-patched e2fsprogs RPM is installed it will
>     incorrectly consider all such long symlinks as bad and remove them.
> 
> We had previously hit problems with Lustre e2fsprogs because we
> originally flagged such symlinks as errors, and there was no
> existing test which had such a symlink.  The description clearly
> wasn't useful for upstream submission, but the test is still useful.

OK, I'll update the commit description and give it a try.  Note that
one of the reasons why we *have* to support extent-mapped long
symlinks is for file systems with > 32-bit block numbers....

	    	     	     	    	   	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html