linux-ext4 - Re: [PATCH] debugfs: cleanup in do_show_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxeRw=byZRehhPYLikEtdBHRAxeu_cN_9iPy_MPVOF8hGdrTg@mail.gmail.com>
Date:	Mon, 16 Apr 2012 22:21:05 +0800
From:	Steven Liu <lingjiujianke@...il.com>
To:	Zheng Liu <gnehzuil.liu@...il.com>
Cc:	linux-ext4@...r.kernel.org, Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH] debugfs: cleanup in do_show_debugfs_params

Hi Zheng Liu,

      What dose this mean, you use printf and not use stdout?


Reviewed-By Steven Liu <LiuQi@...loud.cn>

2012/4/16 Zheng Liu <gnehzuil.liu@...il.com>:
> From: Zheng Liu <wenqing.lz@...bao.com>
>
> Remove 'out' variable and replace fprintf with printf.
>
> Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
> ---
>  debugfs/debugfs.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 590468d..99281ac 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -1973,12 +1973,10 @@ void do_rmdir(int argc, char *argv[])
>  void do_show_debugfs_params(int argc EXT2FS_ATTR((unused)),
>                            char *argv[] EXT2FS_ATTR((unused)))
>  {
> -       FILE *out = stdout;
> -
>        if (current_fs)
> -               fprintf(out, "Open mode: read-%s\n",
> +               printf("Open mode: read-%s\n",
>                        current_fs->flags & EXT2_FLAG_RW ? "write" : "only");
> -       fprintf(out, "Filesystem in use: %s\n",
> +       printf("Filesystem in use: %s\n",
>                current_fs ? current_fs->device_name : "--none--");
>  }
>
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html