linux-ext4 - Re: [PATCH] e2fsck,libquota: Update quota only if its inconsistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120424185231.GH18865@thunk.org>
Date:	Tue, 24 Apr 2012 14:52:31 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Aditya Kali <adityakali@...gle.com>
Cc:	niu@...mcloud.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsck,libquota: Update quota only if its inconsistent

On Fri, Apr 13, 2012 at 01:11:03PM -0700, Aditya Kali wrote:
> Currently fsck recomputes quotas and overwrites quota files
> whenever its run. This causes unnecessary modification of
> filesystem even when quotas were never inconsistent. We also
> lose the limits information because of this. With this patch,
> e2fsck compares the computed quotas to the on-disk quotas
> (while updating the in-memory limits) and writes out the
> quota inode only if it is inconsistent.
> 
> Signed-off-by: Aditya Kali <adityakali@...gle.com>

Thanks, applied with one change:

> +	/* Update quota information if it is inconsistent */
> +	{ PR_6_UPDATE_QUOTAS,
> +	  N_("Updating quota info for quota type %N "),
> +	  PROMPT_NULL, PR_PREEN_OK | PR_NO_OK },
> +

I changed "Updating" to "Update" since we will be asking a question.

  	  	     		       - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html