[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120430221016.GE10105@quack.suse.cz>
Date: Tue, 1 May 2012 00:10:16 +0200
From: Jan Kara <jack@...e.cz>
To: Eric Sandeen <sandeen@...hat.com>
Cc: Matthew Wilcox <matthew@....cx>, Jan Kara <jack@...e.cz>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
ext4 development <linux-ext4@...r.kernel.org>,
Andreas Dilger <adilger@...ger.ca>,
Bernd Schubert <bernd.schubert@...m.fraunhofer.de>
Subject: Re: [PATCH 3/3] ext3: pass custom EOF to generic_file_llseek_size()
On Mon 30-04-12 13:16:04, Eric Sandeen wrote:
> Use the new custom EOF argument to generic_file_llseek_size so
> that SEEK_END will go to the max hash value for htree dirs
> in ext3 rather than to i_size_read()
>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
Looks good. I suppose you want to merge all three patches at once so:
Acked-by: Jan Kara <jack@...e.cz>
Honza
> ---
>
> diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
> index 92490e9..c8fff93 100644
> --- a/fs/ext3/dir.c
> +++ b/fs/ext3/dir.c
> @@ -300,10 +300,11 @@ loff_t ext3_dir_llseek(struct file *file, loff_t offset, int origin)
> {
> struct inode *inode = file->f_mapping->host;
> int dx_dir = is_dx_dir(inode);
> + loff_t htree_max = ext3_get_htree_eof(file);
>
> if (likely(dx_dir))
> return generic_file_llseek_size(file, offset, origin,
> - ext3_get_htree_eof(file));
> + htree_max, htree_max);
> else
> return generic_file_llseek(file, offset, origin);
> }
>
>
--
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists