linux-ext4 - Re: Update of e2fsprogs pu branch and ext4 dev branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <F23120C0-078E-44A2-96F9-521E48178AAC@dilger.ca>
Date:	Wed, 2 May 2012 12:40:21 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Zheng Liu <gnehzuil.liu@...il.com>
Cc:	Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org,
	"Darrick J. Wong" <djwong@...ibm.com>
Subject: Re: Update of e2fsprogs pu branch and ext4 dev branch

On 2012-05-02, at 1:29 AM, Zheng Liu wrote:
> On Sun, Apr 29, 2012 at 05:16:47PM -0400, Theodore Ts'o wrote:
> BTW, I have noticed that in current mainline kernel,
> EXT4_FEATURE_INCOMPAT_INLINEDATA is set to 0x8000.  So I will change it
> in e2fsprogs.  Meanwhile, I will add inline_data option into ext4dev in
> mke2fs.conf.  Later I will send the patch to the mailing list.

Right.  There was at one time EXT4_FEATURE_INCOMPAT_BG_USE_META_CSUM
using 0x2000, but that was is not currently needed.  I think it is a
bad idea to change INCOMPAT_INLINEDATA to use 0x2000 in e2fsprogs,
since there is already 0x8000 in by the upstream kernel.

Also, I don't see EXT4_FEATURE_INCOMPAT_LARGEDIR 0x4000 in e2fsprogs
either.  I submitted patches to reserve this flag in Dec 2011
"[PATCH 02/02] ext2: reserve INCOMPAT_LARGEDIR feature flag" but I
guess it was lost when we discovered the conflict between INLINEDATA
and META_CSUM.

AFAIR, all parties agreed to move INLINEDATA to 0x8000 (as was later
changed by Ted in the kernel) to avoid conflict with META_CSUM (which
was thought to be closer to landing, though it later turned out to
be unnecessary).

Cheers, Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html