Date:	Wed, 2 May 2012 15:29:44 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Theodore Ts'o <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org, "Darrick J. Wong" <djwong@...ibm.com>
Subject: Re: Update of e2fsprogs pu branch and ext4 dev branch

On Sun, Apr 29, 2012 at 05:16:47PM -0400, Theodore Ts'o wrote:
> 
> I have updated the pu ("proposed updates") branch of e2fsprogs to
> include the metadata checksum and inline data patches rebased against
> the lastest changes in the e2fsprogs repository.  Note that these
> patches have not been fully reviewed yet, and are still subject to
> change!  In particular, the metadata checksum patches still have the
> issue with the jbd2 checksuming code breaking 64-bit block numbers, and
> inline data branches are causing a regression test failure.  I've
> integrated them into the pu branch to make it easier for me to review
> and test these changes, and so that other developers can see what is
> going on.
> 
> I also had to make some changes to the last inline data patch so that it
> would apply given the changes which the metadata checksum patch series
> had made to e2fsck/pass2.c.  I am not sure I did all off those changes
> correctly, and I'd invite Darrick and Zheng to take a look at them to
> make sure I didn't really screw something up.

I review these patches and it looks good to me.

BTW, I have noticed that in current mainline kernel,
EXT4_FEATURE_INCOMPAT_INLINEDATA is set to 0x8000.  So I will change it
in e2fsprogs.  Meanwhile, I will add inline_data option into ext4dev in
mke2fs.conf.  Later I will send the patch to the mailing list.

Regards,
Zheng

> 
> As I've mentioned, the regression tests mostly pass, but critically
> missing from both patch series are any kind of regression tests.  I
> would really appreciate it if you would consider creating some of
> those.  We may find some interesting bugs as part of the test creation
> and validation process.
> 
> The pu branch is a **rewinding** branch; that is to say, I will be
> periodically rebasing the patches on the pu branch to take into account
> movement in the e2fsprogs master branch.  If you want to make any
> changes to the patches at this point, please fork the following patch
> queue on github, make the changes, and then (a) send the updated patch
> to the mailing list, and (b) push it to github and ask me to pull it
> from your tree.  That will save me a lot of time.  The github repo is
> at:
> 
> 	git://github.com/tytso/e2fsprogs-cksum-patch-queue.git
>  
> and the github page can be found at:
> 
> 	https://github.com/tytso/e2fsprogs-cksum-patch-queue
> 
> I have been using the "guilt" package to manipulate the patch tree, but
> you can also you quilt for the same purpose.
> 
> 
> I have also added the first half of the metadata checksum patches to the
> ext4 development tree.  Again, I've not fully finished reviewing the
> patches, but they pass the regression test in the standard ext4 modes.
> I haven't had a chance to enable metadata checksuming yet, and the jbd2
> patches clearly need some revision (which is why they aren't in the ext4
> patch queue yet).
> 
> The ext4 patch queue is also on github:
> 
> 	git://github.com/tytso/ext4-patch-queue.git
> 	https://github.com/tytso/ext4-patch-queue/commits/master
> 
> The same comment applies for updating the patches that are on the
> ext4-patch-queue.  Please start with the version of the patches in this
> git tree, since I have had to make some changes so they would apply
> cleanly against the latest kernel release.
> 
> There is a comment in the series file which indicates the commit ID of
> e2fsprogs/ext4 the patchsets are currently based upon.  When I rebase
> the patches to take into account newer commits, I will update the commit
> ID in the series file.
> 
> 						- Ted
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists