linux-ext4 - Re: [PATCH] ext4: fix how i_version is modified and turn it on by default V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 May 2012 13:53:08 -0400
From:	Josef Bacik <josef@...hat.com>
To:	Josef Bacik <josef@...hat.com>
Cc:	linux-ext4@...r.kernel.org, linux-nfs@...r.kernel.org,
	bfields@...ldses.org, adilger@...ger.ca, tytso@....edu,
	jack@...e.cz
Subject: Re: [PATCH] ext4: fix how i_version is modified and turn it on by
 default V2

On Tue, May 15, 2012 at 10:33:16AM -0400, Josef Bacik wrote:
> This makes MS_I_VERSION be turned on by default.  Ext4 had been
> unconditionally doing i_version++ in a few cases anway so the mount option
> was kind of silly.  This patch also removes the update in mark_inode_dirty
> and makes all of the cases where we update ctime also do inode_inc_iversion.
> file_update_time takes care of the write case and all the places where we
> update iversion are protected by the i_mutex so there should be no extra
> i_lock overhead in the normal non-exported fs case.  Thanks,
> 

Ok did some basic benchmarking with dd, I ran

dd if=/dev/zero of=/mnt/btrfs-test/file bs=1 count=10485760
dd if=/dev/zero of=/mnt/btrfs-test/file bs=1M count=1000
dd if=/dev/zero of=/mnt/btrfs-test/file bs=1M count=5000

3 times with the patch and without the patch.  With the worst case scenario
there is about a 40% longer run time, going from on average 12 seconds to 17
seconds.  With the other two runs they are the same runtime with the 1 megabyte
blocks.  So the question is, do we care about this worst case since any sane
application developer isn't going to do writes that small?  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html