linux-ext4 - Re: [PATCH v2 1/2] block: add BH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKLKtzeRNLho7MTM_w2h2+P6gehC4PvkP9VohOJL0+7kAn9VTQ@mail.gmail.com>
Date:	Tue, 22 May 2012 09:48:24 +0530
From:	Saugata Das <saugata.das@...aro.org>
To:	"Theodore Ts'o" <tytso@....edu>,
	Christoph Hellwig <hch@...radead.org>
Cc:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	patches@...aro.org, arnd.bergmann@...aro.org, venkat@...aro.org,
	lporzio@...ron.com, adilger@...ger.ca, bharrosh@...asas.com,
	deepak.saxena@...aro.org
Subject: Re: [PATCH v2 1/2] block: add BH_Meta flag

Hi Ted, Christoph

Will you please provide your feedback for these patch set,
[PATCH v2 1/2] block: add BH_Meta flag
[PATCH v2 2/2] ext4: annotate all meta data requests

If there is no comment then will you please merge them.


Regards
Saugata


On 17 May 2012 17:51, Saugata Das <saugata.das@...ricsson.com> wrote:
> From: Saugata Das <saugata.das@...aro.org>
>
> Today, storage devices like eMMC has special features like data tagging
> (introduced in MMC-4.5 version) in order to improve performance of some
> specific writes. On MMC stack, data tagging is used for all writes which
> has REQ_META flag set. This patch adds the capability to add REQ_META flag
> during meta data write.
>
> Signed-off-by: Saugata Das <saugata.das@...aro.org>
>
> changes in v2:
>        Replaced the conditionals around submit_bh as suggested in the review
>        comments from Boaz
> ---
>  fs/buffer.c                 |    6 ++++--
>  include/linux/buffer_head.h |    2 ++
>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 36d6665..942c75b 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1685,7 +1685,8 @@ static int __block_write_full_page(struct inode *inode, struct page *page,
>        do {
>                struct buffer_head *next = bh->b_this_page;
>                if (buffer_async_write(bh)) {
> -                       submit_bh(write_op, bh);
> +                       submit_bh(write_op |
> +                               (buffer_meta(bh) << __REQ_META), bh);
>                        nr_underway++;
>                }
>                bh = next;
> @@ -1739,7 +1740,8 @@ recover:
>                struct buffer_head *next = bh->b_this_page;
>                if (buffer_async_write(bh)) {
>                        clear_buffer_dirty(bh);
> -                       submit_bh(write_op, bh);
> +                       submit_bh(write_op |
> +                               (buffer_meta(bh) << __REQ_META), bh);
>                        nr_underway++;
>                }
>                bh = next;
> diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
> index 458f497..13bba17 100644
> --- a/include/linux/buffer_head.h
> +++ b/include/linux/buffer_head.h
> @@ -34,6 +34,7 @@ enum bh_state_bits {
>        BH_Write_EIO,   /* I/O error on write */
>        BH_Unwritten,   /* Buffer is allocated on disk but not written */
>        BH_Quiet,       /* Buffer Error Prinks to be quiet */
> +       BH_Meta,        /* Is meta */
>
>        BH_PrivateStart,/* not a state bit, but the first bit available
>                         * for private allocation by other entities
> @@ -124,6 +125,7 @@ BUFFER_FNS(Delay, delay)
>  BUFFER_FNS(Boundary, boundary)
>  BUFFER_FNS(Write_EIO, write_io_error)
>  BUFFER_FNS(Unwritten, unwritten)
> +BUFFER_FNS(Meta, meta)
>
>  #define bh_offset(bh)          ((unsigned long)(bh)->b_data & ~PAGE_MASK)
>  #define touch_buffer(bh)       mark_page_accessed(bh->b_page)
> --
> 1.7.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html