linux-ext4 - Re: [PATCH 10/12] container quota: bill container inodes alloc/free on ext4.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FC76B0D.6020804@oracle.com>
Date:	Thu, 31 May 2012 20:58:53 +0800
From:	Jeff Liu <jeff.liu@...cle.com>
To:	Glauber Costa <glommer@...allels.com>
CC:	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org,
	jack@...e.cz, daniel.lezcano@...e.fr, "Ted Ts'o" <tytso@....edu>,
	bpm@....com, chris.mason@...cle.com, hch@...radead.org,
	christopher.jones@...cle.com, david@...morbit.com,
	tinguely@....com, tm@....ma, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 10/12] container quota: bill container inodes alloc/free
 on ext4.

On 05/31/2012 05:15 PM, Glauber Costa wrote:

> On 05/30/2012 06:59 PM, jeff.liu@...cle.com wrote:
>> +#include "../ns_quotaops.h"
>> +
>>   /*
>>    * ialloc.c contains the inodes allocation and deallocation routines
>>    */
>> @@ -233,6 +235,7 @@ void ext4_free_inode(handle_t *handle, struct
>> inode *inode)
>>       dquot_initialize(inode);
>>       ext4_xattr_delete_inode(handle, inode);
>>       dquot_free_inode(inode);
>> +    ns_dquot_free_inode(inode);
>>       dquot_drop(inode);
> 
> This should be inside dquot_free_inode().

Yeah, Ted also mentioned this before, all name space dquot bill routine
could be placed to dquot_xxx() for VFS quota user.

However, AFAICS, they still have to be exported to other file systems
which have their own quota management module, like XFS.

Thanks,
-Jeff

> 
> No need to go patch inode.c
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html