[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120601041742.GG7897@thunk.org>
Date: Fri, 1 Jun 2012 00:17:42 -0400
From: Ted Ts'o <tytso@....edu>
To: Hugh Dickins <hughd@...gle.com>
Cc: Christoph Hellwig <hch@...radead.org>, linux-ext4@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] ext4: hole-punch use truncate_pagecache_range
On Sun, May 13, 2012 at 01:47:00PM -0700, Hugh Dickins wrote:
> When truncating a file, we unmap pages from userspace first, as that's
> usually more efficient than relying, page by page, on the fallback in
> truncate_inode_page() - particularly if the file is mapped many times.
>
> Do the same when punching a hole: 3.4 added truncate_pagecache_range()
> to do the unmap and trunc, so use it in ext4_ext_punch_hole(), instead
> of calling truncate_inode_pages_range() directly.
>
> Signed-off-by: Hugh Dickins <hughd@...gle.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists