[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAC5umyhJ1mCGHE6i61MKOMr4RxVAh_wUFDWUEPsdtK_rC-o4=A@mail.gmail.com>
Date: Sun, 3 Jun 2012 21:57:42 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Andreas Dilger <adilger@...ger.ca>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"Theodore Ts'o" <tytso@....edu>,
Andreas Dilger <adilger.kernel@...ger.ca>,
"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH v2 10/10] ext4: use memweight()
2012/6/2 Andreas Dilger <adilger@...ger.ca>:
> On 2012-06-02, at 7:40, Akinobu Mita <akinobu.mita@...il.com> wrote:
>
>> Use memweight() to count the total number of bits clear in memory area.
>> This change only affects the code segments enabled by EXT4FS_DEBUG.
>
> Personally, I'd rather still keep a thin wrapper ext4_count_free() and put the memweight() call and math inside that. The function name ext4_count_free() is meaningful to readers, while memweight() is much less so.
OK, I'll make such change to ext[234] if no other people disagree with it.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists