linux-ext4 - Re: [PATCH 5/4] exofs: Handle error from d_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FD611AA.5010006@panasas.com>
Date:	Mon, 11 Jun 2012 18:41:30 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Jan Kara <jack@...e.cz>, Ted Tso <tytso@....edu>,
	<linux-ext4@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 5/4] exofs: Handle error from d_splice_alias()

On 06/09/2012 12:59 AM, Al Viro wrote:

> On Wed, May 30, 2012 at 01:39:08PM +0300, Boaz Harrosh wrote:
>> +	ret = d_splice_alias(inode, dentry);
>> +	if (IS_ERR(ret)) {
>> +		EXOFS_ERR("directory #%lu corrupted", dir->i_ino);
>> +		iput(inode);
> 
> That's a bloody wrong interface.  If you add d_splice_alias() failure
> exit like that, do iput() *there*.  Requiring every caller to deal with
> failure exit cleanups like that is the recipe for recurring bugs.
> Don't Do That.


I agree. Thanks.

My point being that please any changes made to ext2, in this area please also
apply to exofs, since it is just another copy/paste of ext2. I'll ACK any
which way you guys decide to properly go with, as part of the VFS changes.

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html