linux-ext4 - Re: [PATCH] ext4: Avoid unnecessary calls to ext4_mb_load_buddy while reading mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120613235241.GA22646@thunk.org>
Date:	Wed, 13 Jun 2012 19:52:41 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Aditya Kali <adityakali@...gle.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Avoid unnecessary calls to ext4_mb_load_buddy
 while reading mb_groups proc file

On Fri, Jan 14, 2011 at 02:05:15PM -0800, Aditya Kali wrote:
> Currently ext4_mb_load_buddy is called for every group, irrespective
> of whether the group info is already in memory, while reading
> /proc/fs/ext4/<partition>/mb_groups proc file. For the purpose of
> mb_groups proc file, it is unnecessary to load the file group info
> from disk if it was loaded in past. These calls to ext4_mb_load_buddy
> make reading the mb_groups proc file expensive.
> Also, the locks around ext4_get_group_info are not required.
> This patch modifies the code to call ext4_mb_load_buddy only if the
> group info had never been loaded into memory in past. It also removes
> the mb group locking around ext4_get_group_info call.
> 
> Signed-off-by: Aditya Kali <adityakali@...gle.com>

I realized that this had dropped through the cracks.  Sorry!

I've queued this for the next merge window.

     	    	     	      	    - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html