linux-ext4 - Re: [PATCH] change a comment on fs/ext4/extents.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120620155125.GA14203@gmail.com>
Date:	Wed, 20 Jun 2012 23:51:25 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	haiboliu6@...il.com
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] change a comment on fs/ext4/extents.c

Hi Haibo,

If your patch only relates to ext4, please change the patch's subject
like this:
[PATCH] ext4: change a comment on fs/ext4/extents.c

On Tue, Jun 19, 2012 at 11:35:47PM +0800, haiboliu6@...il.com wrote:
> From: HaiboLiu <HaiboLiu6@...il.com>
> 
> May be it's better.

Maybe the following commit log is better:
In this patch (197217a5), ext4_ext_try_to_merge has been changed to
merge an extent both left and right.  So we need to update the comment
in here.

Regards,
Zheng

> 
> Signed-off-by: HaiboLiu <HaiboLiu6@...il.com>
> ---
>  fs/ext4/extents.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 74f23c2..db671b9 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1807,11 +1807,10 @@ has_space:
>  	nearex->ee_len = newext->ee_len;
>  
>  merge:
> -	/* try to merge extents to the right */
> +	/* try to merge extents */
>  	if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
>  		ext4_ext_try_to_merge(inode, path, nearex);
>  
> -	/* try to merge extents to the left */
>  
>  	/* time to correct all indexes above */
>  	err = ext4_ext_correct_indexes(handle, inode, path);
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html