linux-ext4 - Re: [PATCH 1/2] Add a new helper for sleepable BTM acquirements which is used by tty_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120630133549.2431968e@pyramind.ukuu.org.uk>
Date:	Sat, 30 Jun 2012 13:35:49 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	jeff.liu@...cle.com
Cc:	linux-serial@...r.kernel.org,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	gregkh@...uxfoundation.org, Jan Kara <jack@...e.cz>,
	"Ted Ts'o" <tytso@....edu>
Subject: Re: [PATCH 1/2] Add a new helper for sleepable BTM acquirements
 which is used by tty_write_message()

On Sat, 30 Jun 2012 17:39:58 +0800
Jeff Liu <jeff.liu@...cle.com> wrote:

> This helper only used by tty_write_message(), it will sleep until BTM lock acquired.

This makes no sense at all. mutexes already sleep. Your code is also
wrong for real time processes.

So NAK.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html