lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Mon,  2 Jul 2012 22:18:37 +0400
From:	Andrew Perepechko <anserper@...ru>
To:	linux-ext4@...r.kernel.org
Cc:	Andrew Perepechko <andrew_perepechko@...atex.com>
Subject: [PATCH] ext4: remove an unneeded check in ext4_releasepage

From: Andrew Perepechko <andrew_perepechko@...atex.com>

The page_has_buffers() checks in ext3/4_releasepage are not
needed, since ->releasepage() is only called if
page_has_private() is positive.

Signed-off-by: Andrew Perepechko <andrew_perepechko@...atex.com>
---
 fs/ext3/inode.c |    2 --
 fs/ext4/inode.c |    2 --
 2 files changed, 4 deletions(-)

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 9a4a5c4..ee5ef30 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1841,8 +1841,6 @@ static int ext3_releasepage(struct page *page, gfp_t wait)
 
 	trace_ext3_releasepage(page);
 	WARN_ON(PageChecked(page));
-	if (!page_has_buffers(page))
-		return 0;
 	return journal_try_to_free_buffers(journal, page, wait);
 }
 
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 02bc8cb..bfad0a8 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2796,8 +2796,6 @@ static int ext4_releasepage(struct page *page, gfp_t wait)
 	trace_ext4_releasepage(page);
 
 	WARN_ON(PageChecked(page));
-	if (!page_has_buffers(page))
-		return 0;
 	if (journal)
 		return jbd2_journal_try_to_free_buffers(journal, page, wait);
 	else
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists