linux-ext4 - Re: [v2] ext4: delete a no useful sentence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120709142528.GA18072@thunk.org>
Date:	Mon, 9 Jul 2012 10:25:28 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Liu Haibo <haiboliu6@...il.com>
Cc:	linux-ext4@...r.kernel.org, Haibo Liu <HaiboLiu6@...i.com>
Subject: Re: [v2] ext4: delete a no useful sentence

On Thu, Jun 21, 2012 at 08:31:06AM -0000, Liu Haibo wrote:
> From: Haibo Liu <HaiboLiu6@...i.com>
> 
> In this patch, the sentence "poff = block % blocks_per_page"
> in ext4_mb_get_buddy_page_lock has no effect.
> So we should delete it to save cpu.
> 
> v1->v2: update the patch subject and the patch comment.
> 
> Signed-off-by: Haibo Liu <HaiboLiu6@...il.com>

Applied, thanks.  BTW, I modified the patch description a little to
note that the compiler would optimize out the statement, but it's
better to remove unused C statements.

       	  	 				- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html