Message-ID: <1342000571.2963.145.camel@sauron>
Date:	Wed, 11 Jul 2012 12:56:11 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Ted Ts'o <tytso@....edu>
Cc:	Ext4 Mailing List <linux-ext4@...r.kernel.org>
Subject: Some warnings

Hi Ted,

just out of curiosity I've checked the patches you have in the 'dev'
branch with aiaiai - it did not fine anything very bad (but sometimes it
does!), but detected that few warnings.

--------------------------------------------------------------------------------

Successfully built configuration "x86_64_defconfig,x86_64,", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+fs/ext4/ext4.h:1670:47: error: bad constant expression [sparse]
+fs/ext4/ext4.h:1670:47: error: bad constant expression [sparse]
@@ @@
+fs/ext4/resize.c: In function ‘ext4_update_super’:
+fs/ext4/resize.c:1200:9: warning: unused variable ‘ret’ [-Wunused-variable]
@@ @@
+fs/ext4/super.c: In function ‘ext4_statfs’:
+fs/ext4/super.c:4779:15: warning: variable ‘overhead’ set but not used [-Wunused-but-set-variable]

--------------------------------------------------------------------------------

The first one is sparse complaining about using dynamic array as a local
variable which has a potential to blow the stack, generally speaking.

The other ones are just gcc warnings.

In short, aiaia is a script which builds the kernel before patching (and
uses sparse/smatch/coccinelle/cppplus while building) and after patching
and compares to build logs in a smart way, and then tells you about new
warnings/complaints from gcc/sparse/smatch/coccinelle. It also checks
bisectability and reports about failures. I find it very useful for
verifying incoming patches.

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists