linux-ext4 - Re: [PATCH 2/8] exofs: remove lock/unlock super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502CF46A.4040507@panasas.com>
Date:	Thu, 16 Aug 2012 16:23:54 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Marco Stornelli <marco.stornelli@...il.com>
CC:	<bhalevy@...ian.com>, <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	<adilger.kernel@...ger.ca>, <tytso@....edu>,
	<hirofumi@...l.parknet.co.jp>, <mikulas@...ax.karlin.mff.cuni.cz>,
	Al Viro <viro@...IV.linux.org.uk>, <hch@...radead.org>,
	<dushistov@...l.ru>, <osd-dev@...n-osd.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	<linux-ext4@...r.kernel.org>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 2/8] exofs: remove lock/unlock super

On 08/16/2012 01:00 PM, Marco Stornelli wrote:

> From: Marco Stornelli <marco.stornelli@...il.com>
> 
> Remove lock and unlock super operation.
> 


ACK-by: Boaz Harrosh <bharrosh@...asas.com>

> Signed-off-by: Marco Stornelli <marco.stornelli@...il.com>

> ---
> diff -Nurp linux-3.6-rc1-orig/fs/exofs/super.c linux-3.6-rc1/fs/exofs/super.c
> --- linux-3.6-rc1-orig/fs/exofs/super.c	2012-08-16 09:37:31.000000000 +0200
> +++ linux-3.6-rc1/fs/exofs/super.c	2012-08-16 09:45:31.000000000 +0200
> @@ -384,8 +384,6 @@ static int exofs_sync_fs(struct super_bl
>  	if (unlikely(ret))
>  		goto out;
>  -	lock_super(sb);
> -
>  	ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
>  	memset(fscb, 0, ios->length);
>  	fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
> @@ -403,8 +401,6 @@ static int exofs_sync_fs(struct super_bl
>  	else
>  		sb->s_dirt = 0;
>  -
> -	unlock_super(sb);
>  out:
>  	EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret);
>  	ore_put_io_state(ios);


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html