linux-ext4 - Re: [PATCH 3/8] ext3: remove lock/unlock super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120816191909.GC31346@thunk.org>
Date:	Thu, 16 Aug 2012 15:19:09 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	Marco Stornelli <marco.stornelli@...il.com>, bharrosh@...asas.com,
	bhalevy@...ian.com, Andrew Morton <akpm@...ux-foundation.org>,
	adilger.kernel@...ger.ca, hirofumi@...l.parknet.co.jp,
	mikulas@...ax.karlin.mff.cuni.cz,
	Al Viro <viro@...IV.linux.org.uk>, hch@...radead.org,
	dushistov@...l.ru, osd-dev@...n-osd.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 3/8] ext3: remove lock/unlock super

On Thu, Aug 16, 2012 at 06:39:04PM +0200, Jan Kara wrote:
> On Thu 16-08-12 12:00:26, Marco Stornelli wrote:
> > From: Marco Stornelli <marco.stornelli@...il.com>
> > 
> > Replaced lock and unlock super with a new fs mutex s_lock.
>   Hum, is the lock needed at all? Remount & unfreeze both run with s_umount
> held for writing. Thus we already have exclusion between these two calls.
> The same seems to hold for ext4 BTW.

Agreed, it's not clear lock_super() is needed at all for ext4 at this
point.

	     	       		       	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html