linux-ext4 - Re: Test 272 fails for ext3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120820162212.GA17354@quack.suse.cz>
Date:	Mon, 20 Aug 2012 18:22:12 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dave Chinner <david@...morbit.com>
Cc:	Jan Kara <jack@...e.cz>, xfs@....sgi.com, dmonakhov@...nvz.org,
	linux-ext4@...r.kernel.org
Subject: Re: Test 272 fails for ext3

On Fri 17-08-12 08:48:58, Dave Chinner wrote:
> On Thu, Aug 16, 2012 at 11:37:57AM +0200, Jan Kara wrote:
> >   Hello,
> > 
> >   I was looking into why test 272 from xfstests fails for ext3 and the
> > reason is that ext3 does not support direct IO to file with enabled data
> > journalling (open returns EINVAL because ->direct_IO callback is not
> > specified). So I was thinking how to accomodate this fact in the test -
> > the best I found was to just check using xfs_io whether O_DIRECT open
> > succeeds and perform the test only in that case. Attached patch does this
> > or do people have other ideas?
> 
> 
> # ext3 doesn't support direct IO in journalling mode
> ext3_write_opt_list="iflag=noatime conv=notrunc conv=fsync"
> ext4_write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
> 
> if [ $FSTYP = "ext3" ]; then
> 	write_opt_list="$ext3_write_opt_list"
> else
> 	write_opt_list="$ext4_write_opt_list"
> fi
  Yeah, this is probably simpler. Thanks for suggestion. BTW, ext4 also
does not support direct IO and data journalling but it silently falls back
to buffered IO. Anyway new patch is attached.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR

View attachment "0001-Make-test-272-work-for-ext3.patch" of type "text/x-patch" (1250 bytes)