linux-ext4 - Re: [PATCH] ext4: use kmem_cache_zalloc instead of kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAPgLHd92FsHK7S6NA8fg5hn_WCXtCH8DwO95YU8AFuB-pFK9=Q@mail.gmail.com>
Date:	Tue, 28 Aug 2012 21:38:24 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	ashishsangwan2@...il.com
Cc:	tytso@....edu, adilger.kernel@...ger.ca,
	yongjun_wei@...ndmicro.com.cn, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: use kmem_cache_zalloc instead of kmem_cache_alloc/memset

On 08/28/2012 08:34 PM, Ashish Sangwan wrote:
> you can add 1 more.
> In function ext4_mb_new_blocks(), change:
> ac = kmem_cache_alloc(ext4_ac_cachep, GFP_NOFS);
> to
> ac = kmem_cache_zalloc(ext4_ac_cachep, GFP_NOFS); and remove
> memset(ac, 0, sizeof(struct ext4_allocation_context)); from
> ext4_mb_initialize_context().

got it, thanks, will include in the update version patch.

>
> On Mon, Aug 27, 2012 at 10:10 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:
>> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>>
>> Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset().
>>
>> spatch with a semantic match is used to found this problem.
>> (http://coccinelle.lip6.fr/)
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>> ---
>>  fs/ext4/mballoc.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html