linux-ext4 - Re: [PATCH 3/4] ext4: endless truncate due to nonlocked dio readers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fw6xr8xm.fsf@openvz.org>
Date:	Tue, 04 Sep 2012 21:31:49 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	linux-ext4@...r.kernel.org
Cc:	jack@...e.cz
Subject: Re: [PATCH 3/4] ext4: endless truncate due to nonlocked dio readers

On Tue,  4 Sep 2012 21:22:50 +0400, Dmitry Monakhov <dmonakhov@...nvz.org> wrote:
> If we have enough aggressive DIO readers, truncate will wait
> forever inside inode_dio_wait(). It is reasonable to disable
> nonlock DIO read optimization during truncate.
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> ---
>  fs/ext4/inode.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 709ec5a..e696f19 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -4354,7 +4354,9 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
>  	if (attr->ia_valid & ATTR_SIZE) {
>  		if (attr->ia_size != i_size_read(inode))
>  			truncate_setsize(inode, attr->ia_size);
> +		ext4_set_inode_state(inode, EXT4_STATE_DIOREAD_LOCK);
>  		inode_dio_wait(inode);
> +		ext4_set_inode_state(inode, EXT4_STATE_DIOREAD_LOCK);
OOps, sorry  ^^^^^^^^^^^^^^^ this is wrong
should be ext4_clear_inode_state()
>  		ext4_truncate(inode);
>  	}
>  
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html