lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <504782F8.2080005@itwm.fraunhofer.de> Date: Wed, 05 Sep 2012 18:51:04 +0200 From: Bernd Schubert <bernd.schubert@...m.fraunhofer.de> To: "linux-ext4@...r.kernel.org List" <linux-ext4@...r.kernel.org>, "Ted Ts'o" <tytso@....edu> Subject: [PATCH] ext4: ext4_mknod: always set i_op While I was looking through the code, I noticed i_op is not always initialized, although operations such as setattr probably always should be set. ext4: ext4_mknod: always set i_op From: Bernd Schubert <bernd.schubert@...m.fraunhofer.de> ext4_special_inode_operations have their own ifdef CONFIG_EXT4_FS_XATTR to mask those methods. And ext4_iget also always sets it, so there is an inconsistency. Signed-off-by: Bernd Schubert <bernd.schubert@...m.fraunhofer.de> --- fs/ext4/namei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 2a42cc0..d13873d 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -2149,9 +2149,7 @@ retry: err = PTR_ERR(inode); if (!IS_ERR(inode)) { init_special_inode(inode, inode->i_mode, rdev); -#ifdef CONFIG_EXT4_FS_XATTR inode->i_op = &ext4_special_inode_operations; -#endif err = ext4_add_nondir(handle, dentry, inode); } ext4_journal_stop(handle); -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists