linux-ext4 - Re: [PATCH] ext4: do not enable delalloc by default for ext2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504F61D2.9@redhat.com>
Date:	Tue, 11 Sep 2012 11:07:46 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Brian Foster <bfoster@...hat.com>
CC:	linux-ext4@...r.kernel.org, Eric Sandeen <esandeen@...hat.com>,
	Lukas Czerner <lczerner@...hat.com>
Subject: Re: [PATCH] ext4: do not enable delalloc by default for ext2

On 7/13/12 9:23 AM, Brian Foster wrote:
> On 03/27/2012 09:46 AM, Brian Foster wrote:
>> Use traditional ext2 mount options. Do not enable delalloc by default for ext2.
>>
>> Signed-off-by: Brian Foster <bfoster@...hat.com>
>> ---
>>  fs/ext4/super.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 9339009..b08a547 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
>>  	 * enable delayed allocation by default
>>  	 * Use -o nodelalloc to turn it off
>>  	 */
>> -	if (!IS_EXT3_SB(sb) &&
>> +	if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) &&
>>  	    ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0))
>>  		set_opt(sb, DELALLOC);
>>  
>>
> 
> Ping... Any comments on this? Thanks.

Ping again?

Ted, this has my reviewed-by, I think it really makes sense to push in to keep ext2 behavior close to the same as it was in ext2.ko.

Thanks,
-Eric

> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html