linux-ext4 - Re: [PATCH 1/7] ext4: ext4_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871ui65g2r.fsf@openvz.org>
Date:	Thu, 13 Sep 2012 15:15:40 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Zheng Liu <gnehzuil.liu@...il.com>
Cc:	linux-ext4@...r.kernel.org, tytso@....edu, jack@...e.cz,
	wenqing.lz@...bao.com
Subject: Re: [PATCH 1/7] ext4: ext4_inode_info diet

On Thu, 13 Sep 2012 18:50:22 +0800, Zheng Liu <gnehzuil.liu@...il.com> wrote:
> On Sun, Sep 09, 2012 at 09:27:08PM +0400, Dmitry Monakhov wrote:
> > Generic inode has unused i_private pointer which may be used as cur_aio_dio
> > storage.
> > 
> > TODO: If cur_aio_dio will be passed as an argument to get_block_t this allow
> >       to have concurent AIO_DIO requests.
> 
> Out of curiosity, could you please describe your idea about concurrent
> AIO_DIO requests in get_block_t?  Thanks!
Current buffer.c API layering looks sub-optimal

->xxx_fs_routine: May create different contexts
   ->generic_buffer_methods(inode, bh..)
     ->xxx_fs_get_block(inode, bh,...): There is no efficient way to pass fscontext 
Both xxx_fs_routine and xxx_fs_get_block are fs specific, but
the only way to pass fscontext down to get_block is to pass it by
attaching it to inode, which make it implicit serialization point.

I just want to add fsprivate argument to get_block_t callback similar
write_begin/write_end and iocb->private, so filesystem will able to pass
it to it's get_block callback.
 
> 
> > 
> > Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>
> 
> Looks good to me.  You can add:
> Reviewed-by: Zheng Liu <wenqing.lz@...bao.com>
> 
> Regards,
> Zheng
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html