lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 19 Sep 2012 21:40:30 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
CC:	linux-ext4@...r.kernel.org, fio@...r.kernel.org
Subject: Re: [PATCH 0/4] ioengine: File based ioengines

On 2012-09-19 21:22, Dmitry Monakhov wrote:
> Fio is very cool tool for generating various io patterns.
> And I use it as a base io-loader for xfsstress framework
> 
> I've prepared two file-based ioengines which allow to generate
> interesting io patterns. 'falloc' is more generic and may be useful
> for many cases, other 'e4defrag' is more specific but still
> usfull. It would be nice to have this engines in-tree if possible.
> 
> TOC:
>  # fixes for external engines
>  export file_lookup_open
>  ioengine: allow several external ioengines
>  # file based ioengines
>  ioengine: Add fallocate ioengine
>  ioengine: Add e4defrag ioengine

This looks nifty, especially the fallocate engine. I've added the
patchset, thanks a lot.

Care to send a bit more careful documentation on both of them? The
commit message for fallocate is good, something like that in the HOWTO
would be useful. Bonus points for updating the man page, too! And
e4defrag seems largely undocumented. Some comments in the sample files
(which are great to have, btw) would be nice too.

Will also want wiring up on options.c, the ioengine part, now that they
are in tree.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists