linux-ext4 - Re: [PATCH 3/4] ext4: basic bug shield for move_extent_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120926165007.GC18983@thunk.org>
Date:	Wed, 26 Sep 2012 12:50:07 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org, a-fujita@...jp.nec.com
Subject: Re: [PATCH 3/4] ext4: basic bug shield for move_extent_per_page

Applied, thanks.

I added one sanity check:

> +	for(bh = head, block_start = 0; bh != head || !block_start;
> +	    block++, block_start = block_end, bh = bh->b_this_page) {
  	    ...
		BUG_ON(nr >= MAX_BUF_PER_PAGE);
> +		arr[nr++] = bh;
> +	}

...just to make sure a corrupted link list on b_this_page can't cause
a on-stack array overrun.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html