linux-ext4 - Re: [PATCH] ext4: fix double unlock buffer mess during fs-resize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120926032629.GB11468@thunk.org>
Date:	Tue, 25 Sep 2012 23:26:29 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org, djwong@...ibm.com
Subject: Re: [PATCH] ext4: fix double unlock buffer mess during fs-resize

On Fri, Sep 07, 2012 at 02:14:44PM +0400, Dmitry Monakhov wrote:
> bh_submit_read() is responsible for unlock bh on endio
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>

Thanks, applied.  

BTW, I was checking the call sites for ext4_get_bitmap() in
fs/ext/resize.c, and we doing some extra work in
ext4_set_bitmap_checksums(); if the bitmap is uninitialized, then
there's no point in generating a checksum for it.

Something we can fix later, since it's harmless, although it is extra
unnecessary work.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html